Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot was not able to determine that CI was successful. #7805

Closed
1 task done
KyleSanderson opened this issue Aug 13, 2023 · 7 comments
Closed
1 task done

Dependabot was not able to determine that CI was successful. #7805

KyleSanderson opened this issue Aug 13, 2023 · 7 comments
Labels
T: bug 🐞 Something isn't working

Comments

@KyleSanderson
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

all

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

KyleSanderson/upgraderr#1

Updated dependency

No response

What you expected to see, versus what you actually saw

Dependabot seems to post some unhelpful information after a command is taken.

The quote is @dependabot squash and merge will squash and merge this PR after your CI passes on it
If you use the command, before CI completes, it posts the below message(?).

Dependabot was not able to determine that CI was successful.

Please try again once CI has succeeded.

This feels very silly, and should instead post if the command action fails, which is scheduled properly on action completion and behaves as expected.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@KyleSanderson KyleSanderson added the T: bug 🐞 Something isn't working label Aug 13, 2023
@LeoMcA
Copy link

LeoMcA commented Aug 14, 2023

I don't believe we've made any change in our repo, and we're suddenly seeing dependabot PRs filled with these "Dependabot was not able to determine that CI was successful." messages, in this case commenting 8 times before merging the PR.

@tamird
Copy link

tamird commented Aug 14, 2023

Yeah, dependabot seems to be spamming this (e.g. aya-rs/aya#754 (comment)). It seems to be harmless (the PR eventually merges), but annoying.

@JasonGross
Copy link

This did not used to be the case, but when dependabot comments 16+ times on every PR before merging, it severely clutters PR discussions.

@landongrindheim
Copy link
Member

👋 We've just shipped a fix for this issue so that should prevent Dependabot from commenting when a merge has been requested. Thanks for reporting! 😄

@tamird
Copy link

tamird commented Aug 17, 2023

Would you mind referencing the fix?

@landongrindheim
Copy link
Member

@tamird The fix was made to the Dependabot service, which is hosted in an internal, private, repo.

The summary of the fix is that Dependabot will retry a merge request when CI status requirements have not been met and the commenting behavior was not accounting for this.

@KyleSanderson
Copy link
Author

Nice - thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants