-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot was not able to determine that CI was successful. #7805
Comments
I don't believe we've made any change in our repo, and we're suddenly seeing dependabot PRs filled with these "Dependabot was not able to determine that CI was successful." messages, in this case commenting 8 times before merging the PR. |
Yeah, dependabot seems to be spamming this (e.g. aya-rs/aya#754 (comment)). It seems to be harmless (the PR eventually merges), but annoying. |
This did not used to be the case, but when dependabot comments 16+ times on every PR before merging, it severely clutters PR discussions. |
👋 We've just shipped a fix for this issue so that should prevent Dependabot from commenting when a merge has been requested. Thanks for reporting! 😄 |
Would you mind referencing the fix? |
@tamird The fix was made to the Dependabot service, which is hosted in an internal, private, repo. The summary of the fix is that Dependabot will retry a merge request when CI status requirements have not been met and the commenting behavior was not accounting for this. |
Nice - thank you |
Is there an existing issue for this?
Package ecosystem
all
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
No response
dependabot.yml content
KyleSanderson/upgraderr#1
Updated dependency
No response
What you expected to see, versus what you actually saw
Dependabot seems to post some unhelpful information after a command is taken.
The quote is
@dependabot squash and merge will squash and merge this PR after your CI passes on it
If you use the command, before CI completes, it posts the below message(?).
This feels very silly, and should instead post if the command action fails, which is scheduled properly on action completion and behaves as expected.
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
No response
Smallest manifest that reproduces the issue
No response
The text was updated successfully, but these errors were encountered: