Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yank all 0.2 versions older than 0.2.36 #107

Closed
faern opened this issue Dec 1, 2020 · 5 comments
Closed

Yank all 0.2 versions older than 0.2.36 #107

faern opened this issue Dec 1, 2020 · 5 comments

Comments

@faern
Copy link
Contributor

faern commented Dec 1, 2020

Due to #106. If the standard library ever do change the memory layout of SocketAddr, usage of this crate of versions before 0.2.36 will have undefined behaviour and invalid memory access and lead to segfaults. And even if the standard library never do change the layout of those types, those versions of this crate still makes assumptions they should not.

This is exactly what yanking is for. Marking a release as "should not be used". I think all versions of net2 from 0.2.0 through 0.2.35 should be yanked from crates.io.

Related issues on other crates having the same problem: rust-lang/socket2#139, tokio-rs/mio#1412

@jclulow
Copy link
Member

jclulow commented Dec 5, 2020

Should we also yank all 0.1 versions? It seems like that addr2raw() implementation has been there since the beginning:

42bc921#diff-917ff224180b881299cdcef7bc14e710509229092ea4e6599861680bc0a2a458R65-R74

@faern
Copy link
Contributor Author

faern commented Dec 5, 2020

It has the same bug yes. We have not released any patch release fixing it for the 0.1 branch. But looking at the download stats, it has virtually zero downloads. Yes yank them IMO, they are unsound

@faern
Copy link
Contributor Author

faern commented Dec 7, 2020

Ping @jclulow ?

@pfmooney
Copy link
Member

pfmooney commented Dec 9, 2020

I believe all of the older versions have been yanked.

@pfmooney pfmooney closed this as completed Dec 9, 2020
@faern
Copy link
Contributor Author

faern commented Dec 9, 2020

Amazing! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants