Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: createHTMLDocument needs mandatory title when invoked in IE #1442

Merged
merged 2 commits into from
Mar 18, 2019
Merged

test: createHTMLDocument needs mandatory title when invoked in IE #1442

merged 2 commits into from
Mar 18, 2019

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Mar 18, 2019 •
edited by stephenmathieson
Loading

fix breaking test in IE.
Reference - https://developer.mozilla.org/en-US/docs/Web/API/DOMImplementation/createHTMLDocument

Closes issue: NA

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Stephen

@jeeyyy jeeyyy requested a review from a team as a code owner March 18, 2019 11:05
stephenmathieson
stephenmathieson previously requested changes Mar 18, 2019
View reviewed changes
test/checks/mobile/css-orientation-lock.js Outdated Show resolved Hide resolved
@jeeyyy jeeyyy merged commit 8542773 into develop Mar 18, 2019
@jeeyyy jeeyyy deleted the fix-test-ie branch March 18, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeeyyy @stephenmathieson