-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule,check): add new apis to run a rule synchronously #1467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not looked at tests yet. But left some quick inline comments. Will have a thorough look after the changes are made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small points.
Just curious, but why not run the rules with their async hops in these environments? Also, non-browser environments that have DOM nodes?? :) Is this specifically about JSDOM compat? |
@paulirish there's a new product we're hacking on that has these requirements. Stay tuned :) |
Note: the files were mostly copied from the asynchronous versions and modified to be run in a synchronous way. A few tests were deleted that no longer applied to a synchronous version.
Linked issue: #1550
Reviewer checks
Required fields, to be filled out by PR reviewer(s)