Feat: pt_BR localization #1756
Feat: pt_BR localization #1756
Conversation
- Add pt_BR localization for Axe messages
|
@thiagoeec Just wanted to drop you a quick message. Nobody on the axe-core team is familiar with Portuguese. We are looking for someone to help us review this pull request. This is a fantastically cool contribution, and we're very happy with it. Thank you so much for putting this together. We'll try to get this reviewed as soon as possible. |
|
@WilcoFiers , thanks for the feedback. |
|
@thiagoeec Much appreciated! I did find someone to help with the review. This may take a week or two. |
| "fail": "A página não tem um cabeçalho (header)" | ||
| }, | ||
| "heading-order": { | ||
| "pass": "Hierarquia de títulos válida", |
There was a problem hiding this comment.
The WCAG PT_BR translation for header is "cabeçalho", not "título"
There was a problem hiding this comment.
As discussed before.
| "fail": "A tag <meta> força atualizações temporizadas da página" | ||
| }, | ||
| "p-as-heading": { | ||
| "pass": "Elementos <p> não são estilizados como títulos", |
There was a problem hiding this comment.
The WCAG PT_BR translation for header is "cabeçalho", not "título"
There was a problem hiding this comment.
As discussed before.
There was a problem hiding this comment.
And the word in English used here is 'heading' and not 'header'.
| }, | ||
| "incompleteFallbackMessage": { | ||
| "undefined": { | ||
| "failureMessage": "Corrija todos os itens a seguir:{{~it:value}}\n {{=value.split('\\n').join('\\n ')}}{{~}}" |
There was a problem hiding this comment.
This is not a translation of
"incompleteFallbackMessage": "axe couldn't tell the reason. Time to break out the element inspector!"
But I might be looking at the wrong place
There was a problem hiding this comment.
Axe message is not actually that. The right one is this:
"failureMessage": "Fix all of the following:{{~it:value}}\n {{=value.split('\\n').join('\\n ')}}{{~}}"
So, I think the translation is correct.
|
@thiagoeec could you have a look at Carlos' feedback? |
Hi, @carlosapaduarte. I'll check on your comments as soon as possible. Thanks for reviewing it. |
|
@thiagoeec have you had a chance to look over the comments? If not, we could try to take this over and update the strings per carlos's suggestions. |
Sorry for the long delay. It has been some busy weeks. |
Altered according to @carlosapaduarte suggestions.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)