Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-roles): report error for fallback roles #1970

Merged
merged 7 commits into from
Jan 27, 2020
Merged

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 6, 2020

Closes issue: #1916

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner January 6, 2020 22:35
lib/checks/aria/fallbackrole.js Outdated Show resolved Hide resolved
lib/checks/aria/fallbackrole.json Outdated Show resolved Hide resolved
lib/rules/aria-roles.json Show resolved Hide resolved
lib/checks/aria/invalidrole.js Outdated Show resolved Hide resolved
@straker straker merged commit a1b7e08 into develop Jan 27, 2020
@straker straker deleted the fallbackRoles branch January 27, 2020 16:27
@straker
Copy link
Contributor Author

straker commented Jan 27, 2020

@jeankaplansky just new remediation messages about fallback roles not being supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants