feat(matches): use VirtualNode and deprecate HTMLElement #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
straker
changed the title
straker
changed the title
WilcoFiers
previously requested changes
Jan 23, 2020
| assert.isTrue( | ||
| fromDefinition(node, { | ||
| fromDefinition(virtualNode.actualNode, { |
There was a problem hiding this comment.
Why aren't you passing virtualNode itself in?
There was a problem hiding this comment.
Because the test suite is making sure it still works with actual nodes passed in (backwards compatibility)
WilcoFiers
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow VirtualNode to be used in
axe.commons.matches. I also addedaxe.utils.matcheswhich is a VirtualNode implementation ofElement.matchesso we could handle CSS selectors in the matches function. It's mostly a copy paste of the QSA code with a slight modification to handle working up the parent tree for selectors. I thought about replacing ouraxe.utils.matchesSelectorcode with the new implementation, but it would technically be a breaking change as we restrict the allowed combinators to just>as well as which pseudos we support to just:not.axe.utils.convertExpressionis just a copy paste from the QSA code to convert CSS selectors to the expression object we use in QSA and nowutils.matches. I didn't want to add it oraxe.utils.matchesExpressionto the public API (since they are only used as shared code), but I was unsure how to have both QSA and matches share functions.Closes issue: #1967
Reviewer checks
Required fields, to be filled out by PR reviewer(s)