Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: add element to NodeResults #2211

Merged
merged 3 commits into from
May 6, 2020
Merged

types: add element to NodeResults #2211

merged 3 commits into from
May 6, 2020

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented May 5, 2020

Add the element property to NodeResult interface.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@koddsson koddsson requested a review from a team as a code owner May 5, 2020 07:30
@CLAassistant
Copy link

CLAassistant commented May 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@straker
Copy link
Contributor

straker commented May 5, 2020

Thanks for the pr. Where were you seeing the element property of NodeResult? I'm not seeing it myself.

image

@koddsson
Copy link
Contributor Author

koddsson commented May 6, 2020

Screenshot 2020-05-06 at 09 26 52

I think you need to pass elementRef: true into the options parameter.

@straker
Copy link
Contributor

straker commented May 6, 2020

Ah, that makes more sense. Thanks.

@straker straker merged commit 2429355 into dequelabs:develop May 6, 2020
@koddsson koddsson deleted the patch-1 branch May 6, 2020 14:58
@koddsson
Copy link
Contributor Author

Hey @straker 👋🏻

I just noticed that v3.5.4 has been released but it doesn't include this change. At which point do commits in the develop branch end up in a release?

@straker
Copy link
Contributor

straker commented May 28, 2020

Sorry about that. We've been working on a 4.0 release and just needed to get a bug fix out for color-contrast a bit earlier. This will be in the 4.0 release.

@koddsson
Copy link
Contributor Author

Sorry about that. We've been working on a 4.0 release and just needed to get a bug fix out for color-contrast a bit earlier. This will be in the 4.0 release.

Ah no worries! I was just curious as when the change would land. Thanks for the explanation.

paulirish pushed a commit to paulirish/axe-core that referenced this pull request Jun 5, 2020
@paulirish
fix(axe.d.ts): add element to NodeResults (dequelabs#2211)
85eb52c 
* types: add `element` to NodeResults

* make the element property optional

* actually make it a HTMLElement
@dylanb
Copy link
Contributor

dylanb commented Aug 10, 2020

@straker don't forget to check the security review checkbox - change is obviously ok but...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koddsson @CLAassistant @straker @dylanb