feat(aria/lookupTable, aria-allowed-attr): deprecate aria.lookupTable and passing allowed attributes to aria-allowed-attr #2395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr officially closes #2108 as it removes all lookup table references in our codebase expect where we still need it (mostly for
implicitNodes
which is deprecated as well and keepinglookupTable
as a public API).I noticed the
aria-allowed-attr
test still used the lookup table to configure the options test, which shouldn't have worked. Digging further I found multiple things wrong with that test that would cause it to never fail.First, without
mccheddarton
being configured into the standards object, the check would always pass as there was no allowed role data for an invalid role. Second, sincearia-snuggles
was not configured into the standards object, it would not be counted as a valid attribute so wouldn't fail on it either. Lastly, even if those were configured, since we pass the options to force the allowed attrs the test could never fail.So to fix it I added an assert that proved that without the options the check should fail, which requires properly configured standards.
I also deprecated the options to ara-allowed-attrs as we had done with aria-required-attrs, and refactored the code while I was there to not use
var
.Closes issue: #2108
Reviewer checks
Required fields, to be filled out by PR reviewer(s)