fix(color-contrast): dont error for floating element #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found this as a bug when testing on a site.
straker
changed the title
straker
changed the title
|
Probably. I'll have to go dig around the color-contrast test code for where this code would be triggered |
WilcoFiers
previously requested changes
Aug 12, 2020
WilcoFiers
approved these changes
Aug 14, 2020
straker
added a commit
that referenced
this pull request
Sep 8, 2020
* Update reduce-to-elements-below-floating.js Found this as a bug when testing on a site. * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this as a bug when testing on a site. The variable is reassigned to an empty array under certain conditions.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)