Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target-spacing rule #2652

Closed
WilcoFiers opened this issue Nov 19, 2020 · 2 comments
Closed

Add target-spacing rule #2652

WilcoFiers opened this issue Nov 19, 2020 · 2 comments
Assignees
Labels
feat New feature or enhancement pr A pr has been created for the issue wcag 2.2
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Nov 19, 2020

I wrote a load of test cases on how to do this:

https://codepen.io/wilcofiers/pen/abZxPow

I'd like to implement this rule while WCAG 2.2 is still in draft, so that it can be used for testing. We can take it out of "experimental" as soon as WCAG 2.2 becomes a recommendation.

@WilcoFiers WilcoFiers added the feat New feature or enhancement label Nov 19, 2020
@WilcoFiers WilcoFiers added this to the axe-core 4.2 milestone Nov 19, 2020
@WilcoFiers WilcoFiers modified the milestones: axe-core 4.2, axe-core 4.3 Mar 24, 2021
@WilcoFiers WilcoFiers modified the milestones: axe-core 4.3, Axe-core 4.4 Jun 28, 2021
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.4, Axe-core 4.5 Dec 14, 2021
@WilcoFiers WilcoFiers added the pr A pr has been created for the issue label Sep 5, 2022
@WilcoFiers WilcoFiers changed the title Add experimental target-spacing rule Add target-spacing rule Sep 6, 2022
@padmavemulapati
Copy link

@straker , can you please give QA notes to validate this ticket

@padmavemulapati
Copy link

Validated with the latest axe-core develop branch code base,
test script for the failure in target-size rule:

<!-- Failed examples -->
  <p>
    <button id="failCase1">x</button
    ><span role="button" tabindex="0" id="failCase2">x</span>
  </p>
  
  <ul>
    <li><a href="#" id="failCase3">Item1</a></li>
    <li><a href="#" id="failCase4">Item2</a></li>
  </ul>
  
  <p>
    <input type="checkbox" id="failCase5" /><input type="checkbox" id="failCase6" /><input
      type="text"
      id="pass-adjacent"
    />
  </p>
  

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or enhancement pr A pr has been created for the issue wcag 2.2
Projects
None yet
Development

No branches or pull requests

3 participants