Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--request-timeout affects logs streaming #1381

Closed
mogaika opened this issue Dec 16, 2021 · 2 comments
Closed

--request-timeout affects logs streaming #1381

mogaika opened this issue Dec 16, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mogaika
Copy link
Contributor

mogaika commented Dec 16, 2021




Describe the bug
If you provide --request-timeout 30s argument to k9s and open pod logs, then in ~30 seconds your stream disconnects with message on screen (when using old k9s version v0.24.15)

stream failed: &http.httpError{err:"context deadline exceeded (Client.Timeout or context cancellation while reading body)", timeout:true}

And nothing on screen for latest released version, but still message in k9s logfile:

5:06AM WRN Stream READ error "XXX_REDACTED_XXX"::"default" error="context deadline exceeded (Client.Timeout or context cancellation while reading body)"

Expected behavior
--request-timeout should have effect only on requests, but not log streams.

Versions (please complete the following information):

  • OS: linux
  • K9s: v0.24.15 and v0.25.12
  • K8s: v1.18.10

Additional context
Also it would be great if k9s had indication that log stream disconnected and you have to reconnect (maybe red exclamation point next to since-time indicator).

Old version style error message in pod logs confused me multiple times and I had hard time trying to find ouy why we have http disconnects in services for no reason 😄

@derailed derailed added the bug Something isn't working label Dec 16, 2021
@derailed
Copy link
Owner

@mogaika Thank you Vladimir for this excellent report!! Great catch! On your second point I think #1291 refers to it.

@derailed
Copy link
Owner

@mogaika Fixed v0.25.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants