Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Name 'Ma' treated as a suffix #26

Closed
lebailly opened this issue Jan 13, 2015 · 1 comment
Closed

Last Name 'Ma' treated as a suffix #26

lebailly opened this issue Jan 13, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@lebailly
Copy link

In [1]: HumanName('Andrew Ma')
Out[1]: 
<HumanName : [
    title: '' 
    first: 'Andrew' 
    middle: '' 
    last: 'Ma' 
    suffix: ''
    nickname: ''
]>

In [2]: HumanName('Ma, Andrew')
Out[2]: 
<HumanName : [
    title: '' 
    first: 'Andrew' 
    middle: '' 
    last: '' 
    suffix: 'Ma'
    nickname: ''
]>

In line 1 the name is correctly parsed. However in line 2 (when it is listed "last name, first") the Ma is treated as a suffix and there is no last name. In my opinion, since there is no last name the parser should assume it's a last name and not a suffix.

@derek73 derek73 added the bug label Jan 13, 2015
@derek73
Copy link
Owner

derek73 commented Jan 13, 2015

I agree, this feels like a bug. All of the comma variations should work the same. Probably missing a test someplace and not too hard a fix.

@derek73 derek73 self-assigned this Mar 2, 2015
@derek73 derek73 added this to the v0.3.4 milestone Mar 2, 2015
@derek73 derek73 closed this as completed in 91a9360 Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants