Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the require function from config.pp #124

Closed
PierreR opened this issue Feb 7, 2019 · 1 comment · Fixed by #125
Closed

Remove the require function from config.pp #124

PierreR opened this issue Feb 7, 2019 · 1 comment · Fixed by #125

Comments

@PierreR
Copy link
Contributor

PierreR commented Feb 7, 2019

Do you really need this require/include ?

require ::zookeeper::install

I guess this is because you initialize the datastore at the end of the file ? Still the order is already managed in init.pp and I am wondering (knowing nothing about zookeeper per se) if this initialization really belongs in a config.pp file.

Anyhow this is annoying for use, because we use a testing tool that prohibits the usage of the require function. When we really need it we prefer chaining Class with ->.

Thanks for your support !

@deric
Copy link
Owner

deric commented Feb 20, 2019

I think the require statement is redundant in this case, as we already have chaining -> in here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants