Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Could not find a declaration file for module 'fathom-client'" #62

Closed
evadecker opened this issue Jul 10, 2024 · 3 comments · Fixed by #63
Closed

"Could not find a declaration file for module 'fathom-client'" #62

evadecker opened this issue Jul 10, 2024 · 3 comments · Fixed by #63

Comments

@evadecker
Copy link

Hi!

As of v3.7.0, fathom-client has started throwing an error in TypeScript. This seems like it was partially resolved in #61 but I'm still encountering a blocking error.

On v3.7.1 today:

Could not find a declaration file for module 'fathom-client'. '/Users/Eva/Sites/namesake.fyi/node_modules/.pnpm/[email protected]/node_modules/fathom-client/dist/fathom-client.esm.js' implicitly has an 'any' type.

There are types at '/Users/Eva/Sites/namesake.fyi/node_modules/fathom-client/types/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'fathom-client' library may need to update its package.json or typings.

This error is not present in v3.6.0.

I'm using pnpm and the script is being loaded as a module within Astro.

@derrickreimer
Copy link
Owner

derrickreimer commented Jul 10, 2024

Oh joy. Could you try pointing your dependencies to git://github.com/derrickreimer/fathom-client.git#d4bf37b to see if that resolves it in your environment?

@derrickreimer
Copy link
Owner

Released 3.7.2. We are now all green on https://arethetypeswrong.github.io/, so I'm pretty confident this should be good shape in most (all?) environments now. Please do let me know if you run into trouble again!

@evadecker
Copy link
Author

Confirm that 3.7.2 fixes the issue! Thank you for the incredibly speedy fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants