Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Variables as Kernel Parameters #7

Closed
anirrudh opened this issue Apr 15, 2021 · 4 comments
Closed

Environment Variables as Kernel Parameters #7

anirrudh opened this issue Apr 15, 2021 · 4 comments
Assignees
@anirrudh
Labels
backend changes related to any python-side changes high priority High Priority Tasks tthat need immediate attention

Comments

@anirrudh
Copy link
Contributor

anirrudh commented Apr 15, 2021 •
edited by Carreau
Loading

Ideally, environment variables can be set by IPython before launching the instance. This would ideally be passed in a KernelSpec configuration as one of the key values or as part of the metadata.

Since this is a new feature, barring tracking the implementation details here, the bulk of the conversation surrounding this format will take place at: jupyterlab/jupyterlab/issues/9374
@anirrudh anirrudh added backend changes related to any python-side changes high priority High Priority Tasks tthat need immediate attention labels Apr 15, 2021
@anirrudh anirrudh self-assigned this Apr 15, 2021
@anirrudh anirrudh mentioned this issue Apr 15, 2021
Closed
@anirrudh anirrudh changed the title Environment Variables as Parameters Environment Variables as Kernel Parameters Apr 15, 2021
@ericdatakelly ericdatakelly added this to the April 2021 milestone Apr 20, 2021
@ericdatakelly ericdatakelly modified the milestones: April 2021, May 2021 May 10, 2021
@anirrudh anirrudh reopened this May 26, 2021
@anirrudh
Copy link
Contributor Author

Typings are off, currently. Enlisting @tonyfast and @goanpeca for help :)

@ericdatakelly ericdatakelly modified the milestones: May 2021, June 2021 Jun 7, 2021
@ericdatakelly ericdatakelly modified the milestones: June 2021, July 2021 Jul 8, 2021
@ericdatakelly ericdatakelly modified the milestones: July 2021, August 2021 Aug 12, 2021
@echarles
Copy link
Contributor

We have env variable in the kernelspec editing. For the user to provide environment variables, this will depend on the current JEP and not on the work done in this repository.

Can this be closed?

@Carreau
Copy link
Contributor

Carreau commented Aug 26, 2021

Up to you, I'm not sure why this requires the JEP, but I'll trust you.

Closing.

@Carreau Carreau closed this as completed Aug 26, 2021
@echarles
Copy link
Contributor

Up to you, I'm not sure why this requires the JEP, but I'll trust you.

FYI This is the JEP I was referring to jupyter/enhancement-proposals#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anirrudh anirrudh

Labels
backend changes related to any python-side changes high priority High Priority Tasks tthat need immediate attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@echarles @Carreau @anirrudh @ericdatakelly