-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash collision checks (PyInf#11487) #294
Comments
Internal ticket for tracking: PyInf#11487. |
Reading this code a little more closely, I think this will not work in its current form, because writing data to a file happens in two stages:
So we actually can't index into |
I see, we also need to consider |
Something like this should work?
|
In light of our recent issues with hashing (see #280 and #288), we should add a simple sanity check when we write chunks. In particular I am thinking we should modify the logic in
write_dataset
hereversioned-hdf5/versioned_hdf5/backend.py
Lines 128 to 135 in ee3efe0
to add a check like
I'd argue that this check will be very fast (compared to the SHA256 computation at least!) so the extra overhead will be negligible.
The text was updated successfully, but these errors were encountered: