Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App stops locking pull requests after some time #5

Closed
dessant opened this issue May 4, 2018 · 5 comments
Closed

App stops locking pull requests after some time #5

dessant opened this issue May 4, 2018 · 5 comments

Comments

@dessant
Copy link
Owner

dessant commented May 4, 2018

Pull request update times are ignored by the updated filter, notice the updated label for search results listing a more recent date than what was requested:
https://github.com/babel/babel/pulls?q=updated%3A%3C2018-02-01+is%3Aclosed+sort%3Aupdated-desc+is%3Apr

Issues are filtered as expected:
https://github.com/babel/babel/issues?utf8=%E2%9C%93&q=updated%3A%3C2018-02-01+is%3Aclosed+sort%3Aupdated-desc+is%3Aissue

We have to use the updated filter to get lockable issues without parsing the entire issue list, because there is no filter for unlocked issues. The updated filter bug causes the app to stop locking pull requests once at least 30 of them have been locked.

I have contacted GitHub support about the issue, will update this thread once we get a response.

@dessant
Copy link
Owner Author

dessant commented May 6, 2018

Thanks for reaching out about this! We have an issue open about this already and I've added your report there.
Basically, a PR is a special kind of issue. And sometimes the updated_at information from the PR doesn't sync with the updated_at info for the underlying issue.
I don't have an ETA on when this might be fixed, but we'll follow up as soon as there's news!

@dessant
Copy link
Owner Author

dessant commented May 6, 2018

Starting ecb0e91 issues and prs are searched separately, so this bug only affects pull requests now, issues are locked as expected even without setting the only: issues config option.

@dessant dessant changed the title App stops locking after some time App stops locking pull requests after some time May 6, 2018
@dessant
Copy link
Owner Author

dessant commented May 7, 2018

It turns out there is an undocumented filter for is:locked, and is:unlocked also seems to work. We would need the latter, but it isn't supported yet by GitHub, and it conflicts with is:closed or state:closed.

The query also lists open pull requests at the moment:
https://github.com/babel/babel/pulls?utf8=%E2%9C%93&q=updated%3A%3C2018-02-01+sort%3Aupdated-desc+is%3Apr+is%3Aclosed+is%3Aunlocked

@dessant
Copy link
Owner Author

dessant commented Jan 18, 2019

The is:unlocked search qualifier now appears to work as expected. Issues were also being missed, so existing installations will see a new wave of locking after this release.

@hzoo
Copy link
Contributor

hzoo commented Oct 3, 2019

Not sure why I wasn't subscribed to this anymore but glad it was fixed!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants