Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v2 API #30

Open
davidus05 opened this issue Jun 28, 2018 · 11 comments
Open

Upgrade to v2 API #30

davidus05 opened this issue Jun 28, 2018 · 11 comments

Comments

@davidus05
Copy link

The API-provider https://www.football-data.org/ just changed to v2. So the old v1 version will be removed in the future.

A upgrade of the script would be great. Thanks!

@aminvakil
Copy link
Contributor

Does it work until the end of WC2018?

@davidus05
Copy link
Author

Yes, I think so. -> https://www.football-data.org/documentation/quickstart

"The old v1 API will remain available for the foreseeable future, but I do recommend you migrate to the new v2 API ASAP. The v1 API documentation can still be accessed."

@cmihaylov
Copy link
Member

cmihaylov commented Jul 2, 2018

World Cup 2018 should be fine.
It doesn't look like v1 will soon stop working, but I will look into the changes introduced in v2 and see what we need to change in the logic to make it work with it.

@aminvakil
Copy link
Contributor

Any progress on this?
As UCL 18/19 will continue to next year it should be changed to make it compatible with v2.
Here is changelog:
https://www.football-data.org/documentation/api#changelog
I will try to change it to make it work with v2.

@aminvakil
Copy link
Contributor

aminvakil commented Nov 26, 2018

I've made it compatible with v2, but I can't open a pull request to push my changes to repository, What should I do? @cmihaylov @davidus05

@davidus05
Copy link
Author

Great work, thanks!
I saw your pull already here: #34
I will have to modify the files manually I think - I see your changes there. Maybe @cmihaylov will remove this restriction.

@aminvakil
Copy link
Contributor

I'm idiot in git. Please fix it yourself.
Thanks. @davidus05

@cmihaylov
Copy link
Member

@aminvakil great work on the api v2 changes. I will review your pull request later today and merge it.

@aminvakil
Copy link
Contributor

So far I checked it on importing UCL matches only, maybe we should wait until the end of day and see what happens after games today and will we face any problem or not. @cmihaylov

@cmihaylov
Copy link
Member

OK, cool. I'll try to validate it myself too if all works as expected.

@cmihaylov
Copy link
Member

I did some minor fixes to the pull request and merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants