Skip to content
This repository has been archived by the owner on Dec 26, 2020. It is now read-only.

Missing indent for ChrootDirectory in Match Group sftponly #221

Closed
wojciech-kopras opened this issue May 7, 2019 · 2 comments
Closed

Missing indent for ChrootDirectory in Match Group sftponly #221

wojciech-kopras opened this issue May 7, 2019 · 2 comments
Labels

Comments

@wojciech-kopras
Copy link

Describe the bug
Resulting indentation is incorrect since v6.1.0. Because of introduced - in f911ea9#diff-cf4cfd6ab432cbfc8900283cfd984d0fL243

Expected behavior
In sshd_config I would expect:

Match Group sftponly
    ForceCommand internal-sftp -l INFO -f LOCAL6
    ChrootDirectory /home/%u
    AllowTcpForwarding no

Actual behavior
Result:

Match Group sftponly
    ForceCommand internal-sftp -l INFO -f LOCAL6
ChrootDirectory /home/%u
    AllowTcpForwarding no

Example Playbook


OS / Environment

Ansible Version


Role Version

6.1.0

Additional context
Add any other context about the problem here.

@artem-sidorenko
Copy link
Member

@wojciech-kopras thanks for raising this issue! My I ask you to open a PR with a fix?

@rndmh3ro rndmh3ro added the bug label May 7, 2019
@rndmh3ro
Copy link
Member

rndmh3ro commented May 7, 2019

Hey @wojciech-kopras,

sorry for this! I fixed this in #222, see here in the travis-logs that its fixed: https://travis-ci.org/dev-sec/ansible-ssh-hardening/jobs/529463999#L1133-L1165

I'll merge this and create a new release!

@rndmh3ro rndmh3ro closed this as completed May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants