Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/services page #21

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feature/services page #21

wants to merge 4 commits into from

Conversation

JoyOffiong
Copy link
Collaborator

Description

Clone the repository,create a branch for your whatever you wanna work on, then add, commit and push to the repository and create a PR. Do ensure there is no conflict in your PR. Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • YES
  • NO

Checklist:

  • My code follows the style guidelines of this project
  • I have attached screenshots of the output of this task
  • I have performed a self-review of my own code
  • I followed the Sass 7-1 Architecture and BEM Methodology
  • My changes generate no conflicts
  • I have ran yarn build-css or npm run build-css

Copy link
Contributor

@John-pels John-pels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

There's an alignment issue.

Also, the grid does not look well on Mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants