Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicks on the second defaultHeight item and then flinging cause unexpected scroll #3

Open
amanzan opened this issue Nov 28, 2017 · 4 comments

Comments

@amanzan
Copy link

amanzan commented Nov 28, 2017

It's a little hard to explain, but I'll do my best. When clicking on the first defaultHeight item (the one right after the expanded item), behavior is just fine, you can keep clicking and flinging and it works perfect.

When clicking on the second, third (and so on) defaultHeight items, expanding animation works fine, but then when you fling from top to down, all the items get contracted. Second item should get expanded.

If you don't understand what I mean, I can try to make a GIF to explain.

Thanks for this cool list animation! 👍

@amanzan
Copy link
Author

amanzan commented Nov 28, 2017

Actually, here is a gif. I clicked on the 4th item, then tried to fling from top to down. The blue car item should have been expanded down and then follow normal order. Hope you get what I mean!
ezgif com-optimize

@developer-shivam
Copy link
Owner

Hi @amanzan, I know about this issue. I've made something very much like this with a different approach. Please refer this https://github.com/developer-shivam/FeaturedRecyclerView

@amanzan
Copy link
Author

amanzan commented Nov 29, 2017

I know your other library :) actually I was using it before this one, but I prefer this approach since I had a hard time implementing the "click-to-expand" in your FeatureRecyclerView. Also, I'd like to remove the scroll, so that you can only move with clicks or flings.

Any hint about how to proceed to fix the issue on this project? Thanks a lot @developer-shivam

@amanzan
Copy link
Author

amanzan commented Nov 29, 2017

I don't know if it's the best way to do it, but I created a pull request that fixes the issue. Check it out and feel free to merge it if you think is useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants