Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contrast #121

Closed
torgeirl opened this issue Dec 16, 2022 · 2 comments
Closed

Improve contrast #121

torgeirl opened this issue Dec 16, 2022 · 2 comments
Labels
wcag
Milestone
Trix 4.1

Comments

@torgeirl
Copy link
Contributor

torgeirl commented Dec 16, 2022 •
edited
Loading

Alongside upgrading Django from 3.2 to 4.2 (#119) we need to address issues with too low contrast.

Known issues as of 3.0.0b.16:
@torgeirl torgeirl added the wcag label Dec 16, 2022
@torgeirl torgeirl added this to the Trix 3.1 milestone Dec 16, 2022
@torgeirl torgeirl changed the title Improved contrast Improve contrast Dec 16, 2022
@torgeirl torgeirl modified the milestones: Trix 4.0, Trix 4.1 Nov 29, 2023
@Levijatan
Copy link
Collaborator

The course admin assignment overview page contrast error seems to be a false positive. Because of how the menu is implemented it takes the colour of the element behind the menu background not the menu background colour. Trix probably could use a refactor of the ui.

@Levijatan
Copy link
Collaborator

Fixed the contrast issues I could find inn editor and course admin assignment overview page
9a22163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wcag
Projects
None yet
Milestone
Trix 4.1
Development

No branches or pull requests
2 participants
@torgeirl @Levijatan