Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: make pytest import optional #2455

Closed
wants to merge 1 commit into from
Closed

examples: make pytest import optional #2455

wants to merge 1 commit into from

Conversation

mloubout
Copy link
Contributor

Fix #2454

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 87.05%. Comparing base (42398c4) to head (4698a7d).

Files with missing lines Patch % Lines
examples/seismic/acoustic/acoustic_example.py 50.00% 2 Missing ⚠️
examples/seismic/elastic/elastic_example.py 50.00% 2 Missing ⚠️
examples/seismic/model.py 50.00% 2 Missing ⚠️
examples/seismic/self_adjoint/test_utils.py 50.00% 2 Missing ⚠️
...amples/seismic/self_adjoint/test_wavesolver_iso.py 50.00% 2 Missing ⚠️
examples/seismic/test_seismic_utils.py 50.00% 2 Missing ⚠️
examples/seismic/tti/tti_example.py 50.00% 2 Missing ⚠️
...les/seismic/viscoacoustic/viscoacoustic_example.py 50.00% 2 Missing ⚠️
...mples/seismic/viscoelastic/viscoelastic_example.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2455      +/-   ##
==========================================
- Coverage   87.08%   87.05%   -0.04%     
==========================================
  Files         238      238              
  Lines       45118    45145      +27     
  Branches     8408     8408              
==========================================
+ Hits        39291    39300       +9     
- Misses       5094     5112      +18     
  Partials      733      733

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mloubout mloubout mentioned this pull request Sep 11, 2024
Merged
EdCaunt
EdCaunt reviewed Sep 12, 2024
View reviewed changes
examples/seismic/acoustic/acoustic_example.py
import pytest
try:
import pytest
except:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bare except; should this be ModuleNotFoundError?

@mloubout
Copy link
Contributor Author

Dione in #2456

@mloubout mloubout closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdCaunt EdCaunt EdCaunt left review comments

Assignees
No one assigned
Labels
examples examples installation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest import in examples
2 participants
@mloubout @EdCaunt