Text alignment of events on homepage is weird

[mattstratton]

See seattle for example

[bridgetkromhout]

Although this says Backlog it also is still part of the v1.0 release milestone; I don't really understand if that combination is intentional or leftover. Thanks.

[mattstratton]

Label or GH project?

[bridgetkromhout]

My workflow for "what do we still need to do before we release" is to look at https://github.com/devopsdays/devopsdays-theme/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22v1.0+Release%22 and I think I am missing something, since there are things in there (like this issue) which seem like we wouldn't block the release on them.

[mattstratton]

I'm saying ignore the word "backlog". Use the milestone. This one IS a blocker because I don't feel comfortable releasing with it as is.

[bridgetkromhout]

I'm saying ignore the word "backlog". Use the milestone.

Cool, thanks.

This one IS a blocker because I don't feel comfortable releasing with it as is.

Okay.

[bridgetkromhout]

I noticed that I can't reproduce this problem locally. Maybe that's a clue?

[bridgetkromhout]

I swapped a 300px image out and swapped a 500px image in, and it fixed the mis-alignment. I think this could be related to image sizes.

[mattstratton]

Misunderstood which issue this was. This isn't an issue anymore. Closing.

[mattstratton]

Oh it still does happen in the dev site.

Probably due to the image resizing in the workflow? Do you see it in a deploy preview?

[mattstratton]

Oh yeah it's totally because Seattle's image is too small.

We can do some cleverness in the image processing to ensure they are 500px square at least I suppose.

[bridgetkromhout]

You're right. I reverted and it's not a problem in the deploy preview:

[bridgetkromhout]

We can do some cleverness in the image processing to ensure they are 500px square at least I suppose.

Seattle (300x300), Raleigh (300x300), and Chicago (300x300) are all below what seems to be the threshold and they appear offset. Amsterdam (354x354) looks fine so the cut-off isn't that much above 300.

Sounds like either you do something in the image processing, and/or we increase the size of these images as a short-term fix, or other...?

[bridgetkromhout]

As expected, the larger images band-aid the cosmetic problem without resolving the underlying issue. That is probably our shortest path to not having to fix this before v1.0. Given that we have a workaround, do you still regard this as a v1.0 blocker?

a) Either fixing this goes on the checklist
or
b) Dropping the larger images in place for those three and running through any others that are available to double-check their size goes on the checklist.

[mattstratton]

Fixing the image resizing in gulp is super easy and something I should do prior to v1.0 release.

[mattstratton]

This was fixed in #264