Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

CSS is a big jumbly mess #235

Open
mattstratton opened this issue Feb 17, 2017 · 4 comments
Open

CSS is a big jumbly mess #235

mattstratton opened this issue Feb 17, 2017 · 4 comments
Milestone

Comments

@mattstratton
Copy link
Member

Definitely could use some collapsing.

For example, there are a lot of classes set up for h1 tags on speaker pages, etc, but they don't seem all that different than the main h1 selector.

@mattstratton mattstratton added this to the v1.0 Release milestone Feb 17, 2017
@mattstratton
Copy link
Member Author

The main reason that I think this is important to fix, is not to be pedantic, but because it makes the SCSS really hard to read, and much tougher to figure out stuff that is duplicated.

Also, I just realized I'm calling colors directly, and it's more useful to do that in SCSS properly.

For example, this is defined: $navbar-light-color: #0082AB;

but all over the place I just refer to the color #0082AB

@mattstratton
Copy link
Member Author

Also worth looking at...in site.scss we import custom-variables.scss before all the bootstrap stuff, which means we cannot override the bootstrap variables. I'm not sure why I made this choice. I should try moving custom-variables.scss after the boostrap one just to see.

@mattstratton mattstratton modified the milestones: v1.1 Release, v1.0 Release Feb 20, 2017
@mattstratton
Copy link
Member Author

I was wrong - we need custom-variables.scss after the bootstrap one to over-ride the values.

@mattstratton mattstratton modified the milestone: Next Tasks Mar 20, 2017
@mattstratton mattstratton modified the milestone: Blue Sky May 11, 2017
@mattstratton mattstratton changed the title CSS is a bit jumbly mess CSS is a big jumbly mess Sep 5, 2018
@mattstratton
Copy link
Member Author

I think that this includes #367

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant