You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.
The main reason that I think this is important to fix, is not to be pedantic, but because it makes the SCSS really hard to read, and much tougher to figure out stuff that is duplicated.
Also, I just realized I'm calling colors directly, and it's more useful to do that in SCSS properly.
For example, this is defined: $navbar-light-color: #0082AB;
but all over the place I just refer to the color #0082AB
Also worth looking at...in site.scss we import custom-variables.scss before all the bootstrap stuff, which means we cannot override the bootstrap variables. I'm not sure why I made this choice. I should try moving custom-variables.scss after the boostrap one just to see.
Definitely could use some collapsing.
For example, there are a lot of classes set up for
h1
tags on speaker pages, etc, but they don't seem all that different than the mainh1
selector.The text was updated successfully, but these errors were encountered: