Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

Fix aspect ratio issue on local event contact page #266

Closed
bridgetkromhout opened this issue Feb 20, 2017 · 13 comments
Closed

Fix aspect ratio issue on local event contact page #266

bridgetkromhout opened this issue Feb 20, 2017 · 13 comments
Labels
Milestone

Comments

@bridgetkromhout
Copy link
Contributor

We aren't constraining the aspect ratio for the images:
screen shot 2017-02-20 at 1 15 11 pm

@bridgetkromhout bridgetkromhout added this to the v1.0 Release milestone Feb 20, 2017
@mattstratton
Copy link
Member

Yep. that's because, well, that's how card work in bootstrap.

They smush until they collapse.

@mattstratton
Copy link
Member

We can probably experiment with what the size dimensions work best for it.

@mattstratton
Copy link
Member

Could also just dump using the cards and use the same type of layout as we did for speakers, although I suspect they will act up.

@mattstratton
Copy link
Member

Need to look at the gulp image processing

@mattstratton mattstratton mentioned this issue Feb 20, 2017
24 tasks
@mattstratton
Copy link
Member

Fixed in #268

@clebio
Copy link

clebio commented Feb 25, 2017

Is this deployed? The aspect ratio appears wrong, in the other direction, to me right now.
https://dev.devopsdays.org/events/2017-ponyville/contact
screen shot 2017-02-25 at 8 50 33 am

@mattstratton
Copy link
Member

@clebio what browser and screen size? We fixed this along with some other stuff a while ago (I've since put in a fix that handled ie11; that might have caused weirdness for you)

@clebio
Copy link

clebio commented Feb 25, 2017

@mattstratton macbook pro scaled more space ("looks like 1920 x 1200); Chrome Version 56.0.2924.87

@mattstratton
Copy link
Member

OK, so something responsive is not happening here, because when I rescale, they get smaller, but they don't clear when I change.

I'm going to reopen this issue to chase it down, although it seemed to work fine when I set my screen size to approximately that size (OS X, but on super large external monitor as my 13" MBPr won't get that big). I'll dig.

@mattstratton mattstratton reopened this Feb 25, 2017
@mattstratton
Copy link
Member

I'm thinking my fixnis going to be constraining the organizer images to a specific ratio and resizing them in the gulp task. I think setting height: auto is what is messing us up.

@mattstratton
Copy link
Member

@clebio I think that this has been fixed - can you test it for me?

@clebio
Copy link

clebio commented Feb 26, 2017

Yes, looks good on my end! @mattstratton 👍

@mattstratton
Copy link
Member

Fixed in #331

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants