Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

Follow-up on #300 squished images in IE11 #379

Closed
MikeRosTX opened this issue Mar 14, 2017 · 5 comments
Closed

Follow-up on #300 squished images in IE11 #379

MikeRosTX opened this issue Mar 14, 2017 · 5 comments

Comments

@MikeRosTX
Copy link

Expected behavior

Using 600x600 jpg images and would like them to display in IE11 as the do in Chrome.
Might need to use 300x300 jpg images to properly get them displayed in both browsers.
chrome

Actual behavior

In IE11 they kind of look as squished up. Not as in #300, but not acceptable.
ie11

Reproduction Steps

Operating System and Version

Same as in #300,

Web Browser and Version

Same as in #300.

Next Step

Will add a comment once I change images to 300x300.

@MikeRosTX
Copy link
Author

MikeRosTX commented Mar 14, 2017

Steps Completed

Images were changed to 300x300 in #1994 and they images are acceptable in IE11 and Chrome. I'm sure they look fine in Firefox, but don't have this browser installed to actually know.

Not sure it this is worth mucking with it now so close to RTM or just simply change the Readme and mess with the 600xx600 image size at a later date. Requesting @mattstratton and/or @bridgetkromhout review.

@mattstratton
Copy link
Member

If they were pushed through the full prod workflow, they'd be fine (they are resized for retina to various sizes but you won't see that until it's built to master and only after 3/15's build pipeline)

@mattstratton
Copy link
Member

Can you try http://test.devopsdays.org/events/2017-chicago/contact/ in IE11? This is what they will look like when fully processed (the source images are a mix of 300x300 and 600x600; they get created for retina during the merge to master portion).

I tested it on IE11 on my Surface, and they seem fine.

@mattstratton
Copy link
Member

@MikeRosTX I believe that this works as designed?

@mattstratton mattstratton added question and removed bug labels Mar 16, 2017
@mattstratton
Copy link
Member

I'm going to close this one out as I believe it works as designed. Please feel free to re-open the issue if you disagree :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants