-
Notifications
You must be signed in to change notification settings - Fork 12
document how logo-square is not wysiwyg or make it wysiwyg #590
Comments
Yeah, unless we want to run the image processing pipeline on every deploy preview (which we probably don't, since it takes 2-3 minutes at least), you're going to get this happening. It happens locally too; not just deploy previews. It's probably worth documenting what happens during a production deploy so there aren't surprises. |
Yeah, I figured that was the answer. I think we should make it explicit so people aren't confused when what you see is not what you get. And maybe could we give a command-line switch that a) warns it will take a while and b) requires whatever tools to exist locally but then will produce a perfect wysiwyg local option? |
Oof. That's really complex. Mostly because it won't work with the local I have a to-do at some point to move the CSS generation and javascript uglification/combination out of codekit (which nobody has but me) into gulp; when I do that I will probably be able to make a gulp task that includes watch which will fire up a tiny web server for being able to see things live, at which point we can include this type of thing. I don't really know if it's that big of a deal for the amount of effort that will take; this only comes up if people aren't following the standards anyway, which means they didn't read the docs, which means what good is it to document it further with more complexity? |
We document that it must be square. I've now clarified what that should mean. I'm going to resolve this as good enough. I don't think a local wysiwyg build is essential. |
Expected behavior
In the deploy preview on Netlify, I expect that the layout of the front-page logo squares will look exactly the same as the result I'll get after a deploy.
Actual behavior
Ignore the sort-order problem here, as I'm pretty sure it's orthogonal to the layout problem. What I think is happening is, if the logo square is not actually square, we see the problem before the processing pipeline but it's fixed in processing.
Versus
Reproduction Steps
Look before and after the deploy at Nashville.
If this is unavoidable, then let's document it somewhere such as https://github.com/devopsdays/devopsdays-web/blob/master/utilities/README.md#event-square-logo or https://github.com/devopsdays/devopsdays-theme/blob/master/REFERENCE.md
The text was updated successfully, but these errors were encountered: