Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix twitter stream embedding for event pages #263

Closed
bridgetkromhout opened this issue May 7, 2016 · 3 comments
Closed

fix twitter stream embedding for event pages #263

bridgetkromhout opened this issue May 7, 2016 · 3 comments

Comments

@bridgetkromhout
Copy link
Collaborator

While we have a working twitter feed for the main page, it's built into the layout (https://github.com/devopsdays/devopsdays-web/blob/master/themes/devopsdays-legacy/layouts/partials/twitterfeed.html).

It would be nice to allow events to embed their own twitter feeds - do they need a customized layout to do that? DC's doesn't work when imported with the exact code that worked for webby. See http://devopsdays.github.io/events/2016-washington-dc/contact/ versus what's in the code:

https://github.com/devopsdays/devopsdays-web/blame/master/content/events/2016-washington-dc/contact.md#L12-L13

@bridgetkromhout bridgetkromhout added this to the Future Enhancements milestone May 7, 2016
@bridgetkromhout
Copy link
Collaborator Author

Heads up to @nathenharvey that DC's twitter feed on the contact page isn't working right now. (I've also still got sponsors to import after dinner.) Is the twitter feed a must-have for you before a cutover? Thanks.

@bridgetkromhout
Copy link
Collaborator Author

@nathenharvey says "Cutover without it. Sorry not logged into github from my phone. "

Note: it works on http://devopsdays.github.io/events/2016-oslo/welcome/ - compare and figure out what the difference is.

@bridgetkromhout
Copy link
Collaborator Author

Resolved in #296.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant