Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change speaking page sort order #6548

Closed
bridgetkromhout opened this issue Feb 2, 2017 · 10 comments
Closed

Change speaking page sort order #6548

bridgetkromhout opened this issue Feb 2, 2017 · 10 comments
Assignees

Comments

@bridgetkromhout
Copy link
Collaborator

The sort order for the page introduced in devopsdays/devopsdays-theme#117 defaults to column 3 - in order of when the conference is being held. That seems like it's not the most useful default, since someone coming to this page might reasonably expect the CFP closing soonest to be atop the list (which would mean sorting by column 2).

@mattstratton
Copy link
Member

We haven't bikeshed over this yet, but as a user, I would expect this to be default sorted by CFP dates not event dates.

@bridgetkromhout
Copy link
Collaborator Author

This is trickier than the most obvious solution (of changing https://github.com/devopsdays/devopsdays-theme/blob/master/layouts/partials/speaking.html#L6 to reference the cfp end date) because that won't be set in every case.

@mattstratton
Copy link
Member

Does the page even work if cfp_endate isn't set?

@bridgetkromhout
Copy link
Collaborator Author

If cfp end_date isn't set, then that city just won't show up in this list, in theory. I'll do some testing (out of time now).

@bridgetkromhout bridgetkromhout self-assigned this Feb 3, 2017
@bridgetkromhout
Copy link
Collaborator Author

The page works fine when events don't have cfp_date_end set - they just don't show up. However, I think the map sorting in ascending order is using key, not value, which doesn't do what we want. Further investigation is warranted.

@bridgetkromhout
Copy link
Collaborator Author

If it's possible to make the page open with a default of "and then select and sort by the middle column" that would be an acceptable v1.0 solution for me. (Honestly I don't think this is terrible enough to hold up the release overall.)

@bridgetkromhout
Copy link
Collaborator Author

Clarification: I don't think we hold 1.0 on this.

@bridgetkromhout
Copy link
Collaborator Author

Related to devopsdays/devopsdays-theme#340

@mattstratton mattstratton transferred this issue from devopsdays/devopsdays-theme Mar 11, 2019
@mattstratton
Copy link
Member

#8218 might be the fix for this - with this change, the CFP page is sorted by CFP date by default now. @bridgetkromhout if this is satisfactory to you, we can close this issue.

@mattstratton
Copy link
Member

I am pretty sure @bridgetkromhout told me in Slack this was able to be closed. If not, feel free to re-open :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants