Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fallback support while signing out a device #12

Open
waclaw66 opened this issue Dec 21, 2021 · 5 comments
Open

Missing fallback support while signing out a device #12

waclaw66 opened this issue Dec 21, 2021 · 5 comments

Comments

@waclaw66
Copy link

Please see element-hq/element-web#20292

@Wunderharke
Copy link

See element-hq/element-web#19605.

@spantaleev
Copy link
Member

No upstream progress on these issues, unfortunately.

@timokoesters
Copy link

Interactive auth chooses the first flow it sees

Is it possible to change the order such that shared secret auth is not the first one?

@spantaleev
Copy link
Member

Good idea! It only makes sense if both supported login types (m.login.password and com.devture.shared_secret_auth) are enabled. We can then play around with the order and try to register m.login.password first.

If only com.devture.shared_secret_auth is registered, then it's not applicable.

However.. testing on Synapse v1.53.0, element-hq/element-web#19605 is no longer an issue, because m.login.password is always first in the list regardless of ordering and regardless of whether shared-secret-auth enables the m.login.password login type. Looks like this has become a non-issue now - due to an intentional fix on the Synapse side or due to some random change. I've reported this here

@Sharparam
Copy link

Sharparam commented Mar 24, 2022

m.login.password is not listed first on my Synapse v1.55.0 instance, so this is still an issue. Perhaps some version after v1.53.0 changed the ordering again.

Edit: Response after Element calls /_matrix/client/r0/delete_devices when trying to remove an old device:

{
  "session": "<snip>",
  "flows" : [
    {
      "stages": [ "com.devture.shared_secret_auth" ]
    },
    {
      "stages": [ "m.login.password" ]
    }
  ],
  "params": {}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants