Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Better handling for invalid filenames when encoding #90

Closed
LolicoreExpress opened this issue Sep 6, 2022 · 5 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@LolicoreExpress
Copy link

I think this is an area that could use a small makeover. The "check" for a valid filename seems to happen way after the encode is launched. Sometimes I launch an encode with an invalid filename (some non-allowed character in there) but it will only cancel the encode after 10 long minutes of encoding depending on what I'm cooking. Which can be a bit of a pain.
So why not have the "check" for a wrong filename happen first and foremmost when launching an encode and telling you right off the bat what's wrong with your filename / what characters were not allowed ?
That's something that could save a lot of time and minimize mistakes, I think.

So options I was thinking about were the following:
1- Make the check happen -before- starting the encode and stop if filename is invalid
and/or
1- Improve the auto-naming of encodes (it usualy lefts off characters that are actually allowed)
2- Make a tooltip or something appear, that tells you what characters were not allowed in your filename

@LolicoreExpress
Copy link
Author

LolicoreExpress commented Sep 6, 2022

And just in general. I have encoded stuff with a "/" in the filename, but the program doesn't tell you that the encode failed because the filename had an invalid character in it, so you're just left figuring it out for yourself. Very unfriendly for the average user.

@dfaker dfaker self-assigned this Sep 7, 2022
@dfaker dfaker added the bug Something isn't working label Sep 7, 2022
@dfaker
Copy link
Owner

dfaker commented Sep 8, 2022

I'll see what I can dig out for validation as there are quite a few edge cases, "/" is an interesting case as the filename is being normalised so that will be behaving as if it expects an additional subfolder.

Generally it's trying to default to add additional constraints to an existing filename on the system - so this should only be an issue when you're attempting to supply your own filename.

@dfaker dfaker added the enhancement New feature or request label Sep 8, 2022
@LolicoreExpress
Copy link
Author

Nice, thank you !

@dfaker
Copy link
Owner

dfaker commented Feb 25, 2023

The filename entry on the encode tab will now check as far as possible if the filename is creatable after 7425439 it'll still allow you to force using your selected naming but will highlight the field in red if the name fails checks.

@dfaker dfaker closed this as completed Feb 25, 2023
@LolicoreExpress
Copy link
Author

Awesome, that's perfect. Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants