Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack overflow for Heap.fromIter #578

Open
chenyan-dfinity opened this issue Jul 23, 2023 · 0 comments
Open

Stack overflow for Heap.fromIter #578

chenyan-dfinity opened this issue Jul 23, 2023 · 0 comments

Comments

@chenyan-dfinity
Copy link
Contributor

The current Heap.fromIter/heapify gets stack overflow when there are more than 100k elements: dfinity/canister-profiling#70.

We need to either 1) rewrite the join function with an accumulator; or 2) enable tail modulo cons optimization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chenyan-dfinity