-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this.mount loading/error substates generation. #103
Comments
Will try to look at it this week. Thanks for the link! |
@knownasilya have you had any chance to look into this? If not, would you mind if I picked it up? |
Go ahead, I'm swamped:) |
Will take care of it then |
Should this already work? In my app, using [email protected] & [email protected], loading & error substates do not seem to work for a routeable engine. |
@mydea Can you open a failing test case against this repo as a new issue? |
@mydea to answer your question, it should work, but substates seem to be rather finicky so it could very well be something was missed. |
@mydea Sorry to trouble you, did you manage to get the loading sub-states working on your engines? I tried several combinations to no avail |
Sadly, no - see #193 |
@mydea @andreamancuso We've reduced it to a simple reproduction, it's all set for one of you to dive in and solve it! 😜 (Yes, this is the "PRs accepted" response, but it's not something we're presently trying to solve for at LI and so it's not on the to-do list yet.) |
@nathanhammond where is this reproduction? |
We need the behavior of creating
loading
/error
substates as peers to the engine when usingthis.mount
inside of an application'srouter.js
. The end result will be similar to the implementation here:https://github.com/emberjs/ember.js/blob/master/packages/ember-routing/lib/system/dsl.js#L44-L47
/cc @knownasilya
The text was updated successfully, but these errors were encountered: