Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.mount loading/error substates generation. #103

Closed
nathanhammond opened this issue May 10, 2016 · 12 comments
Closed

this.mount loading/error substates generation. #103

nathanhammond opened this issue May 10, 2016 · 12 comments
Assignees

Comments

@nathanhammond
Copy link
Contributor

nathanhammond commented May 10, 2016

We need the behavior of creating loading/error substates as peers to the engine when using this.mount inside of an application's router.js. The end result will be similar to the implementation here:
https://github.com/emberjs/ember.js/blob/master/packages/ember-routing/lib/system/dsl.js#L44-L47

/cc @knownasilya

@knownasilya
Copy link
Contributor

knownasilya commented Jun 20, 2016

Will try to look at it this week. Thanks for the link!

@trentmwillis
Copy link
Member

@knownasilya have you had any chance to look into this? If not, would you mind if I picked it up?

@knownasilya
Copy link
Contributor

Go ahead, I'm swamped:)

@trentmwillis trentmwillis self-assigned this Jul 14, 2016
@trentmwillis
Copy link
Member

Will take care of it then

@mydea
Copy link
Contributor

mydea commented Sep 9, 2016

Should this already work? In my app, using [email protected] & [email protected], loading & error substates do not seem to work for a routeable engine.

@nathanhammond
Copy link
Contributor Author

@mydea Can you open a failing test case against this repo as a new issue?

@trentmwillis
Copy link
Member

@mydea to answer your question, it should work, but substates seem to be rather finicky so it could very well be something was missed.

@andreamancuso
Copy link

@mydea Sorry to trouble you, did you manage to get the loading sub-states working on your engines? I tried several combinations to no avail

@mydea
Copy link
Contributor

mydea commented Oct 24, 2016

Sadly, no - see #193

@nathanhammond
Copy link
Contributor Author

@mydea @andreamancuso We've reduced it to a simple reproduction, it's all set for one of you to dive in and solve it! 😜 (Yes, this is the "PRs accepted" response, but it's not something we're presently trying to solve for at LI and so it's not on the to-do list yet.)

@knownasilya
Copy link
Contributor

@nathanhammond where is this reproduction?

@nathanhammond
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants