Upstream resolver changes #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmwillis
force-pushed
the
resolver-upstream
branch
from
2bd7828
to
b36a0e5
Compare
trentmwillis
force-pushed
the
resolver-upstream
branch
from
b36a0e5
to
8f57d83
Compare
|
@dgeb and @rwjblue this is passing in Beta, but Canary is failing due to a build issue. Dug into it a bit, but couldn't figure it out. Seems potentially similar to this old issue: emberjs/ember.js#13347 |
|
Failure seems to have resolved itself. I think this should be good to merge. |
|
LGTM |
|
Thanks @trentmwillis |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on: ember-cli/ember-resolver#151.
Also, starts testing against the Beta branch of Ember. Figured we should probably do that if 2.8 is supposed to be compatible with Engines.
Closes: #10