Rename memory metrics #2636
Merged
Rename memory metrics #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename HeapIdle to MemoryIdle * Rename dgraph_heap_idle_bytes to dgraph_memory_idle_bytes * Rename TotalOSMemory to MemoryProc * Rename dgraph_proc_memory_bytes to dgraph_memory_proc_bytes * Remove unused TotalMemory var * Fix typo: "cummulative" -> "cumulative"
Variable used be called "megs" when it was converted from bytes to megabytes, but that is no longer the case. No need to convert from uint64 -> float64 -> int64.
srfrog
approved these changes
Oct 9, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
srfrog
approved these changes
Oct 9, 2018
There was a problem hiding this comment.
Reviewable status:
|
The grafana dashboard will need to be updated too once this is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is