[WIP] Split membership sync endpoints #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, so Zero can use that information to purge Oracle.
golangcibot
reviewed
Nov 25, 2018
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
…o#2773) - Now that Zero followers cannot send proposals to leader, Alphas must send their membership updates to the Zero leader. - The membership updates can be received from any Zero server, leader or follower. - So, this PR splits the job of sending and receiving updates into two different endpoints: StreamMembership and UpdateMembership. - Purge Timestamps are now calculated using the Snapshot timestamp of the group. This is simpler, easier to predict and makes this system run like clockwork. That is, a snapshot calculation in Alpha leader would cause all Alpha followers to get that snapshot, which would then cause Zero to purge the timestamps below that snapshot ts (assuming other groups have caught up). - This removes the need for Zero to query all Alpha leaders, via PurgeTs endpoint. That is now removed. - Removed a lot of error variables, switching them with explanatory errors about what is going on in the system, making things easier to debug. Commits: * Working membership endpoint split. * Removed PurgeTs endpoint. Passing snapshot ts during membership update, so Zero can use that information to purge Oracle. * Block on Tablet call until we find a Zero leader. * More debugging via traces. * Simplify connToZeroLeader. Try to not add new bugs. * Update blockade test with restart option. * Self Reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is