Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new Stream API from Badger #2852

Merged
merged 4 commits into from
Dec 29, 2018
Merged

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Dec 29, 2018

  • Snapshot stream now uses the new Stream API by Badger.
  • During snapshot streaming, we no longer do Rollups.
  • Remove pb.KV in Dgraph. Use the one in Badger.
  • Rename predicate.go to snapshot.go.
  • Bring in the latest version of Badger.
  • Switch Rollup to use the new Badger.Stream API.

This change is Reviewable

@manishrjain manishrjain merged commit eca7d1f into master Dec 29, 2018
@manishrjain manishrjain deleted the mrjn/snapshot-no-rollup branch December 29, 2018 01:35
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
- Snapshot stream now uses the new Stream API by Badger.
- During snapshot streaming, we no longer do Rollups.
- Remove pb.KV in Dgraph. Use the one in Badger.
- Rename predicate.go to snapshot.go.
- Bring in the latest version of Badger.
- Switch Rollup to use the new Badger.Stream API.

Changes:
* Avoid doing a rollup while streaming snapshot. Use the new Badger API for streaming KVs.
* Rename predicate.go to snapshot.go
* Make tests work again.
* Switch Rollup to use the new Badger.Stream API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant