Change the way health checking works. #2956

manishrjain · 2019-01-31T00:03:18Z

Instead of calling Echo repeatedly, have the server return a stream.

This is in response to #2922 .

This change is

…dly, have the server return a stream.

golangcibot · 2019-01-31T00:04:15Z

conn/raft_server.go

+			}
+		}
+	}
+	return nil


unreachable code (from govet)

* Change the way health checking works. Instead of calling Echo repeatedly, have the server return a stream. This should be a more robust approach than calling Echo from the client. In this approach, the server is sending beats to the client, which has a better chance of periodic execution.

Change the way health checking works. Instead of calling Echo repeate…

dc7847a

…dly, have the server return a stream.

golangcibot reviewed Jan 31, 2019

View reviewed changes

conn/raft_server.go Outdated

}

}

}

return nil

Copy link

golangcibot Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unreachable code (from govet)

manishrjain added 2 commits January 30, 2019 16:05

Remove a useless return

a347b49

Add a comment about the approach.

59889d2

manishrjain merged commit f198523 into master Jan 31, 2019

manishrjain deleted the mrjn/echo branch January 31, 2019 00:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change the way health checking works. #2956

Change the way health checking works. #2956

manishrjain commented Jan 31, 2019 •

edited

Loading

golangcibot Jan 31, 2019

Change the way health checking works. #2956

Change the way health checking works. #2956

Conversation

manishrjain commented Jan 31, 2019 • edited Loading

golangcibot Jan 31, 2019

Choose a reason for hiding this comment

manishrjain commented Jan 31, 2019 •

edited

Loading