Print commit SHA256 when invoking "make install" #3786
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@martinmr you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Is this based on some request? I had a chat with Daniel about Dgraph binary printing out the SHA256 checksum of the binary itself.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @danielmai and @manishrjain)
There was a problem hiding this comment.
I was looking at unassigned tasks in asana and this was there.
https://app.asana.com/0/1134394294595169/1134548811140584/f
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @danielmai)
It'd be a bit weird (if not practically impossible) to embed the SHA256 sum into the Dgraph binary for |
There was a problem hiding this comment.
Yeah, I thought about the flaw in that requested logic later. But, we technically don't need to embed the SHA-256 in the binary itself. Could the binary "locate" itself and do a SHA-256 checksum at runtime?
If it is hard, don't worry about it.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @danielmai)
There was a problem hiding this comment.
I can look into that in a separate PR. I still think it's useful to output the commit checksum when running make install
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @danielmai)
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @danielmai)
This change is