Do not use type keys during tablet size calculation. #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the keys used for storing types are used during the tablet size calculation. This leads to an Alpha instructing Zero to delete the tablet for this predicate. This is incorrect since type and predicate names are not equivalent and types do not have an corresponding tablet. The bug is mostly harmless but it could lead to issues if a type has the same name as a predicate.
danielmai
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
mangalaman93
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
|
LGTM. CC: @parasssh you might have a conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the keys used for storing types are used during the tablet
size calculation. This leads to an Alpha instructing Zero to delete the
tablet for this predicate. This is incorrect since type and predicate
names are not equivalent and types do not have an corresponding tablet.
The bug is mostly harmless but it could lead to issues if a type has the
same name as a predicate.
Fixes #4473
This change is