During backup, collapse split posting lists into a single list. #4682
Conversation
Currently, the splits are preserved in a backup, this changes the output of backup to only write a single key per posting list.
There was a problem hiding this comment.
Why is this needed? The list would be split again when the database is running (and splits are enabled).
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)
There was a problem hiding this comment.
This makes backup more robust. If the split logic changes, backups would still work across versions. It's fine if they end up being split again after the restore.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)
There was a problem hiding this comment.
Changed SingleListRollup to re-use l.rollup. l.rollup now gets passed a boolean controlling whether the split should be done.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @danielmai and @manishrjain)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @danielmai)
Splits have been re-enabled in version 1.2.1 after Jepsen tests encoutered no errors. Re-enabling splits in master.
There was a problem hiding this comment.
Added tests.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @danielmai and @manishrjain)
Currently, the splits are preserved in a backup, this changes the output of backup to only write a single key per posting list.
Currently, the splits are preserved in a backup, this changes the output of backup to only write a single key per posting list.
Currently, the splits are preserved in a backup, this changes the
output of backup to only write a single key per posting list.
This change is
Docs Preview: