Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for indexing to complete in Alter #4981

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Wait for indexing to complete in Alter #4981

merged 3 commits into from
Mar 19, 2020

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Mar 19, 2020 •
edited by manishrjain
Loading

This change is Reviewable

@mangalaman93 mangalaman93 requested review from manishrjain and a team as code owners March 19, 2020 18:38
manishrjain
manishrjain approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Can you also add the error message changes from my PR?

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

manishrjain
manishrjain approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Looks good. Once the CI passes, feel free to merge.

Reviewed 11 of 11 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mangalaman93 mangalaman93 merged commit cbbdee8 into master Mar 19, 2020
@mangalaman93 mangalaman93 deleted the aman/background branch March 19, 2020 19:42
danielmai pushed a commit that referenced this pull request Mar 20, 2020
@mangalaman93 @danielmai
Wait for indexing to complete in Alter (#4981)
abd4006 
(cherry picked from commit cbbdee8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain manishrjain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mangalaman93 @manishrjain