Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/v20.03: Alpha: Expose compression_level option (#5278) #5280

Merged
merged 1 commit into from
Apr 23, 2020
Merged

release/v20.03: Alpha: Expose compression_level option (#5278) #5280

merged 1 commit into from
Apr 23, 2020

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Apr 22, 2020 •
edited by dgraph-bot
Loading

This PR exposes the compression_level flag in alpha. The flag can be set as

dgraph alpha --badger.compression_level=xxx

A higher value of the compression level is more CPU intensive but
offers a better compression ratio. The default value is 3.

compression_level=0 disables compression.

(cherry picked from commit 7442993)

This change is Reviewable

Docs Preview: Dgraph Preview

Alpha: Expose compression_level option (#5278)
0af9c59 
This PR exposes the `compression_level` flag in `alpha`. The flag can be set as 
```
dgraph alpha --badger.compression_level=xxx
```
A higher value of the compression level is more CPU intensive but 
offers a better compression ratio. The default value is `3`.

`compression_level=0` disables compression.

(cherry picked from commit 7442993)
@jarifibrahim jarifibrahim requested review from manishrjain and a team as code owners April 22, 2020 20:09
martinmr
martinmr approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @manishrjain)

@jarifibrahim jarifibrahim merged commit cff9940 into release/v20.03 Apr 23, 2020
@jarifibrahim jarifibrahim deleted the ibrahim/release-v20.03-alpha-flag branch April 23, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmr martinmr martinmr approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarifibrahim @martinmr