Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION]: Ristretto hit ratio benchmark result #336

Closed
Yiling-J opened this issue Apr 1, 2023 · 3 comments
Closed

[QUESTION]: Ristretto hit ratio benchmark result #336

Yiling-J opened this issue Apr 1, 2023 · 3 comments
Labels
kind/question Something requiring a response. Stale

Comments

@Yiling-J
Copy link

Yiling-J commented Apr 1, 2023

Question.

Run arc-s3 benchmark in https://github.com/dgraph-io/benchmarks, set MaxCost to 500000 and I got the following result:

name       , label         , go,  mop/s,  ns/op, ac, byt, hits    , misses  ,   ratio
ristretto  , hits-arc-s3   ,  0, ------, ------, --, ---, 00172676, 16235026,   1.05%

My question is about this 1.05% ratio, is this the real hit ratio? From the Ristretto README Benchmarks, the s3 hit ratio with 500000 capacity should be around 50%.

I ask this because I'm developing a similar cache package using W-TinyLFU, I also write some benchmarks and Ristretto hit ratio in my benchmarks are all extreamly low, I think maybe my benchmarks are wrong, so I tried the official dgraph-io/benchmarks and ask here.

@Yiling-J Yiling-J added the kind/question Something requiring a response. label Apr 1, 2023
@Yiling-J Yiling-J changed the title [QUESTION]: Ristretto hit ratio benchamrk result [QUESTION]: Ristretto hit ratio benchmark result Apr 2, 2023
@Yiling-J
Copy link
Author

Yiling-J commented Apr 11, 2023

hit ratio benchmark results of my package and ristretto:
https://github.com/Yiling-J/go-cache-benchmark-plus

@phuslu
Copy link

phuslu commented Jan 30, 2024

Similar result in my linux server (oracle arm machine)

image

cc @Yiling-J @maypok86

Copy link

This issue has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

@github-actions github-actions bot added the Stale label Jul 15, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Something requiring a response. Stale
Development

No branches or pull requests

2 participants