Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when trying to create rich link with unconventional top-level domains like (.art, .design) #23

Open
leo-bianchi opened this issue Mar 14, 2023 · 2 comments

Comments

@leo-bianchi
Copy link

Hello. I've been trying to create rich links with some sites with unusual domains like https://www.growth.design
And I'm getting the following message:
image

The steps to reproduce the error:

  1. Paste URL (https://www.growth.design)
  2. CTRL + P to open command pallete
  3. Search "Rich Link"
  4. Click on it
  5. The message will appear and will not create the nice widget

Obs: I also tested without www, without https and so on
I've tested with .org and .gov domains like (wikipedia.org) (www.state.gov) and it worked properly.
Im uncapable to say if other domains can cause the error.

Anyway, thanks for this great feature. Your plugin is making my notes looks beautiful and well-presented.

@dhamaniasad
Copy link
Owner

I'll look into this, it seems to be related to the other issue #24

@webtechlabs
Copy link

Late to the party on this one but it appears the current regex does not support new TLDs. I created a pull request with a working regex that handles them as well as some case sensitivities that might be causing issues with some people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants