Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react version to resolve UNMET PEER DEPENDENCEY warnings upon install #70

Open
Combinations opened this issue May 28, 2018 · 4 comments

Comments

@Combinations
Copy link

Using react 16.x and react-dom 16.x

running: npm install react-chat-window --save

├── UNMET PEER DEPENDENCY [email protected]
└─┬ [email protected]
  ├─┬ [email protected]
  │ └── [email protected]
  ├─┬ [email protected]
  │ ├── [email protected]
  │ ├── [email protected]
  │ ├─┬ [email protected]
  │ │ └── [email protected]
  │ └── [email protected]
  ├── [email protected]
  ├── UNMET PEER DEPENDENCY react@^0.14.0 || ^15.0.0
  ├── UNMET PEER DEPENDENCY react-dom@^0.14.0 || ^15.0.0
  ├─┬ [email protected]
  │ └── [email protected]
  └─┬ [email protected]
    ├── [email protected]
    ├── [email protected]
    ├── [email protected]
    ├─┬ [email protected]
    │ ├── [email protected]
    │ ├── [email protected]
    │ ├─┬ [email protected]
    │ │ ├── [email protected]
    │ │ ├── [email protected]
    │ │ └── [email protected]
    │ ├─┬ [email protected]
    │ │ ├── [email protected]
    │ │ └── [email protected]
    │ ├── [email protected]
    │ └── [email protected]
    ├── [email protected]
    ├── [email protected]
    ├─┬ [email protected]
    │ └─┬ [email protected]
    │   └── [email protected]
    ├── [email protected]
    ├─┬ [email protected]
    │ ├── [email protected]
    │ ├─┬ [email protected]
    │ │ └── [email protected]
    │ └── [email protected]
    └── [email protected]

npm WARN [email protected] requires a peer of [email protected] but none was installed.
npm WARN [email protected] requires a peer of react@^0.14.0 || ^15.0.0 but none was installed.
npm WARN [email protected] requires a peer of react-dom@^0.14.0 || ^15.0.0 but none was installed.

@dharness
Copy link
Owner

dharness commented May 29, 2018

Looks like react 16.x isn't supported :/ -- PR is welcome

@heatherbooker
Copy link
Contributor

Is there a way for react-chat-window to support 15.x and 16.x as peer dependency options? Or no dice?

@dharness
Copy link
Owner

dharness commented Aug 6, 2018

@heatherbooker probably some if statements combined with React.version; in the worst case, and some clever averaging in the best case. But I'd say yes

@heatherbooker heatherbooker changed the title UNMET PEER DEPENDENCEY warnings upon install Update react version to resolve UNMET PEER DEPENDENCEY warnings upon install Jul 19, 2019
@AppLoidx
Copy link
Contributor

I got this WARNs with react 16.9.0, but react-chat-window still works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants