You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #156 I realized that it's possible to pass an invalid degree and things don't "break", though they should. Parts of this change:
verify=True should be opt-out the same way _copy=True
_copy=True should be promoted to public copy=True (_copy being "internal" is too confusing)
The reason __init__() doesn't do any computation on degree (i.e. the reason the from_nodes() helpers exist) is because computing degree from number of nodes may be expensive (for curves it's just num_nodes - 1 but for triangles / surfaces it requires solving a quadratic) whereas verifying will be less expensive. Also, by making verify a keyword argument, callers have the option to opt-out of the verification.
The text was updated successfully, but these errors were encountered:
In #156 I realized that it's possible to pass an invalid
degree
and things don't "break", though they should. Parts of this change:verify=True
should be opt-out the same way_copy=True
_copy=True
should be promoted to publiccopy=True
(_copy
being "internal" is too confusing)The reason
__init__()
doesn't do any computation ondegree
(i.e. the reason thefrom_nodes()
helpers exist) is because computingdegree
from number of nodes may be expensive (for curves it's justnum_nodes - 1
but for triangles / surfaces it requires solving a quadratic) whereas verifying will be less expensive. Also, by makingverify
a keyword argument, callers have the option to opt-out of the verification.The text was updated successfully, but these errors were encountered: