Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use browser field in package.json if it exists #129

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Oct 21, 2019

We should use the browser field in package.json for dependency resolution, otherwise we might get server code (for packages that distribute both under the same name, like styled-components)

NOTE: The yarn.lock changes in the example app and shell adapter are unrelated, just residual from the previous version bump

@amcgee amcgee requested a review from varl October 21, 2019 13:43
@netlify
Copy link

netlify bot commented Oct 21, 2019

Deploy preview for dhis2-app-platform ready!

Built with commit 5aef0a8

https://deploy-preview-129--dhis2-app-platform.netlify.com

@varl
Copy link
Contributor

varl commented Oct 21, 2019

Perfect. Thanks for the heads up on the lock-bump too. 👍

@varl varl merged commit 33742cc into master Oct 21, 2019
@varl varl deleted the fix/resolve-browser-field branch October 21, 2019 19:35
dhis2-bot added a commit that referenced this pull request Oct 21, 2019
## [1.5.5](v1.5.4...v1.5.5) (2019-10-21)

### Bug Fixes

* use browser field in package.json if it exists ([#129](#129)) ([33742cc](33742cc))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants